Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add(#751): add support for github actions #775

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

add(#751): add support for github actions #775

wants to merge 4 commits into from

Conversation

indiVar0508
Copy link

No description provided.

@indiVar0508 indiVar0508 force-pushed the add_751 branch 7 times, most recently from a7674ec to 9df23b1 Compare June 15, 2023 18:09
@indiVar0508 indiVar0508 mentioned this pull request Jun 15, 2023
Open
@indiVar0508 indiVar0508 changed the title [WIP] : add support for github actions add(#751): add support for github actions Jun 15, 2023
@ananyo2012
Copy link
Contributor

@indiVar0508 This looks good. I have few more task additions.

  • We need to display test results on GitHub CI. Once Enable test reporting #777 is merged it will dump testresults o temp/ directory. Please check this test-reporter GitHub plugin documentation for the same.
  • We need a coverage report summary as well. For this you can explore code-coverage-summary plugin

Also feel free to explore any other tools you seem fit for this and we can discuss here further.

@indiVar0508 indiVar0508 force-pushed the add_751 branch 8 times, most recently from aacbaf4 to 48ddcae Compare June 25, 2023 16:04
@indiVar0508
Copy link
Author

Hi @ananyo2012 ,

Added coverage step and to report it in PR comment which will be update for each run.

I tried adding testing-report but it seems to be failing ig due to the format which is not acceptable by the test-reporter action, getting error in reading file with jest-junit.
ref: https://github.com/indiVar0508/junction/actions/runs/5365317262/jobs/9734065641
.
A workaround ig is to use java-junit but requires to unittest-xml-reporting to generate report which still has some limitations
ref: dorny/test-reporter#244

@ananyo2012
Copy link
Contributor

@indiVar0508 Please check https://github.com/marketplace/actions/publish-test-results as an alternative for test-reporting

@indiVar0508 indiVar0508 force-pushed the add_751 branch 6 times, most recently from 12d5265 to de0c0b8 Compare July 2, 2023 12:11
@indiVar0508
Copy link
Author

Thanks @ananyo2012 ,
I have added same in this PR you can check once ig some permissions from project is required as i saw last time it failed write comment however it was able to write comment in my forked project.
Do let know if anything else is needed to be added or some other issue that i can take up

@ananyo2012 ananyo2012 linked an issue Jul 4, 2023 that may be closed by this pull request
Create new or fix the current CI pipeline #751
Open
@ananyo2012
Copy link
Contributor

@indiVar0508 You need to create a separate workflow for Publishing Results - https://github.com/EnricoMi/publish-unit-test-result-action/blob/v2.8.0/README.md#support-fork-repositories-and-dependabot-branches . Let's Name the first Workflow as 'CI' and second one as 'Test Report'.

Also the Pull request comments should only run during Pull request events, not for master branch.

@indiVar0508 indiVar0508 force-pushed the add_751 branch 5 times, most recently from 4eed168 to 69af5e2 Compare July 4, 2023 18:06
@indiVar0508
chore: added venv in .gitignore
02008e6
@indiVar0508
add(751): add github actions to execute tests
7e32991 
- created workflow directory and test.yml workflow
- added a job that executes existing compose.test.yml file
  to run tests
- job will be triggered when a PR is raised to master or
  push happens to master ( post merge also will trigger a
  job )
- added concurrency check so that old job can be cancelled
  if a new push happens
@indiVar0508
add(751): add coverage report
ff03a49
@indiVar0508 indiVar0508 force-pushed the add_751 branch 3 times, most recently from 4978255 to f1fdfb9 Compare July 4, 2023 18:38
@indiVar0508
Copy link
Author

Added as per comments @ananyo2012

  • renamed the respective workflows
  • encorporated steps metioned in the links
  • comment for coverage reports will posted for pull request event and publish test result seems to already handle this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create new or fix the current CI pipeline
2 participants
@indiVar0508 @ananyo2012